Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SANDBOX-944: update author in Dockerfiles #1098

Closed
wants to merge 2 commits into from
Closed

SANDBOX-944: update author in Dockerfiles #1098

wants to merge 2 commits into from

Conversation

rsoaresd
Copy link
Contributor

Description

Update the author name and email address in the Dockerfiles so that the Docker image metadata reflects the correct contact information.

Issue ticket number and link

SANDBOX-944

MatousJobanek
MatousJobanek reviewed Jan 20, 2025
View reviewed changes
make/ksctl.mk Outdated Show resolved Hide resolved
openshift-ci/Dockerfile.tools Outdated Show resolved Hide resolved
openshift-ci/Dockerfile.tools Outdated Show resolved Hide resolved
scripts/ci/manage-operator.sh Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 20, 2025

@rsoaresd: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e 3e9d042 link true /test e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

MatousJobanek
MatousJobanek approved these changes Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@MatousJobanek MatousJobanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, but you need to re-open it with different branch name as you opened PRs in host and member with the same branch names, so the pairing mechanism fails

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fbm3307, MatousJobanek, rsoaresd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [MatousJobanek,fbm3307,rsoaresd]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rsoaresd
Copy link
Contributor Author

It looks good, but you need to re-open it with different branch name as you opened PRs in host and member with the same branch names, so the pairing mechanism fails

Thanks, going

@rsoaresd rsoaresd closed this Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbm3307 fbm3307 fbm3307 approved these changes

@MatousJobanek MatousJobanek MatousJobanek approved these changes

@xcoulon xcoulon Awaiting requested review from xcoulon xcoulon is a code owner

@alexeykazakov alexeykazakov Awaiting requested review from alexeykazakov alexeykazakov is a code owner

@rajivnathan rajivnathan Awaiting requested review from rajivnathan rajivnathan is a code owner

@ranakan19 ranakan19 Awaiting requested review from ranakan19 ranakan19 is a code owner

@mfrancisc mfrancisc Awaiting requested review from mfrancisc mfrancisc is a code owner

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rsoaresd @MatousJobanek @fbm3307